feat(learn): Collecting code coverage #7006

avivkeller · 2024-08-24T15:34:52Z

Description

This PR introduces a learning article on collecting code coverage in Node.js. However, it should not be merged until support for thresholds is included in the next semver-minor release, which is expected to be next week.

Related Issues

Support for code coverage: nodejs/node#46017
Support for code coverage inclusion/exclusion: nodejs/node#53553
Support for code coverage thresholds: nodejs/node#54429

Check List

I have read the Contributing Guidelines and made commit messages that follow the guideline.
I have run npm run format to ensure the code follows the style guide.
I have run npm run test to check if all tests are passing.
I have run npx turbo build to check if the website builds without errors.
[N/A] I've covered new added functionality with unit tests if necessary.

vercel · 2024-08-24T15:34:55Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nodejs-org	✅ Ready (Inspect)	Visit Preview	Mar 22, 2025 1:36pm

avivkeller · 2024-08-24T15:35:11Z

This is currently marked as draft until the next semver-minor release of Node.js

avivkeller · 2024-08-24T15:37:33Z

https://nodejs-org-git-fork-redyetidev-code-coverage-learn-openjs.vercel.app/en/learn/test-runner/collecting-code-coverage

AugustinMauroy

This is my first feedback, I think the introduction should be improved to put it in context. It should be remembered that the learn section is intended for non-experts.

apps/site/pages/en/learn/test-runner/collecting-code-coverage.md

vercel · 2024-08-24T17:12:55Z

Deployment failed with the following error:

The provided GitHub repository does not contain the requested branch or commit reference. Please ensure the repository is not empty.

AugustinMauroy

LGTM !

apps/site/pages/en/learn/test-runner/collecting-code-coverage.md

mikeesto

Thanks for writing this, reads well

apps/site/pages/en/learn/test-runner/collecting-code-coverage.md

avivkeller · 2024-08-25T23:35:27Z

I've undrafted this, as the release proposal for v22.8.0 is ready at nodejs/node#54560, but it still shouldn't land until that does.

The expected release date is ~~2024-08-26~~ 2024-09-02

github-actions · 2024-08-26T07:18:47Z

Unit Test Coverage Report

Lines	Statements	Branches	Functions
	88.75% (742/836)	76.1% (242/318)	87.65% (142/162)

Unit Test Report

Tests	Skipped	Failures	Errors	Time
182	0 💤	0 ❌	0 🔥	6.096s ⏱️

bmuenzenmeyer

this is great - looking forward to it

AugustinMauroy · 2024-09-02T15:50:48Z

Can we have last review form @nodejs/test_runner

mcollina

This is amazing. However I'm not sure we should be landing this before having stabilized the code coverage functionality.

mcollina

This is amazing. However I'm not sure we should be landing this before having stabilized the code coverage functionality.

avivkeller · 2024-09-02T17:01:53Z

I think this is okay to land once v22.8.0 releases, as it specifies that the --experimental-code-coverage command is needed, indicating that it is experimental. Would you like me to add a notice at the beginning that this is experimental, or just hold off until it's stabilized?

mcollina · 2024-09-02T17:03:33Z

I think it's better to hold off until it's stable.

avivkeller · 2024-10-28T22:11:31Z

IMO code coverage (w/o the --enable-source-maps flag) is pretty stable. I haven't seen many bugs with it in a while.

I asked a few weeks ago, and it was pointed out that statement coverage isn't supported, however, I'm not sure if that's in the plans for the immediate future of code coverage.

The original issue tracking the stability has been closed as completed, as all tasks were completed, which might mean it's ready to be stable. I've left a comment asking.

ovflowd · 2024-11-17T00:33:57Z

I'm fine keeping this open for the meantime, the problem is it becoming stale.

avivkeller · 2024-11-17T01:01:28Z

I'm also happy to close and reopen it, as chances are there will be some significant changes to the coverage reporter before stabilization, and this only collecting merge conflicts.

ovflowd

@avivkeller has there been any change yet? I feel we could merge the PR to be honest.

avivkeller · 2025-03-22T11:35:27Z

It's still experimental, but it's more stable, so I also think this can be merged.

@mcollina are you still blocking?

(I'll resolve the conflicts later today)

mcollina

lgtm

Signed-off-by: Aviv Keller <[email protected]>

Co-authored-by: Michael Esteban <[email protected]> Signed-off-by: Aviv Keller <[email protected]>

Signed-off-by: Aviv Keller <[email protected]>

github-actions · 2025-03-22T13:30:26Z

Lighthouse Results

URL	Performance	Accessibility	Best Practices	SEO	Report
/en	🟢 93	🟢 100	🟢 100	🟢 91	🔗
/en/about	🟢 100	🟢 100	🟢 100	🟢 91	🔗
/en/about/previous-releases	🟢 100	🟢 100	🟢 100	🟢 92	🔗
/en/download	🟢 92	🟢 100	🟢 100	🟢 91	🔗
/en/blog	🟢 99	🟢 100	🟢 96	🟢 92	🔗

avivkeller · 2025-03-22T13:52:11Z

Article published: https://nodejs.org/en/learn/test-runner/collecting-code-coverage

vercel bot deployed to Preview August 24, 2024 15:36 View deployment

vercel bot deployed to Preview August 24, 2024 15:39 View deployment

AugustinMauroy reviewed Aug 24, 2024

View reviewed changes

avivkeller force-pushed the code-coverage-learn branch from ee241d0 to f26b449 Compare August 24, 2024 17:12

avivkeller requested a review from AugustinMauroy August 24, 2024 17:13

AugustinMauroy approved these changes Aug 24, 2024

View reviewed changes

apps/site/pages/en/learn/test-runner/collecting-code-coverage.md Outdated Show resolved Hide resolved

vercel bot deployed to Preview August 24, 2024 20:09 View deployment

mikeesto approved these changes Aug 25, 2024

View reviewed changes

apps/site/pages/en/learn/test-runner/collecting-code-coverage.md Outdated Show resolved Hide resolved

vercel bot deployed to Preview August 25, 2024 11:26 View deployment

avivkeller marked this pull request as ready for review August 25, 2024 23:35

avivkeller requested a review from a team as a code owner August 25, 2024 23:35

avivkeller mentioned this pull request Aug 25, 2024

v22.8.0 proposal nodejs/node#54560

Merged

aymen94 approved these changes Aug 26, 2024

View reviewed changes

AugustinMauroy added the github_actions:pull-request Trigger Pull Request Checks label Aug 26, 2024

github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Aug 26, 2024

AugustinMauroy deployed to Storybook August 26, 2024 07:17 — with GitHub Actions View deployment

bmuenzenmeyer approved these changes Aug 26, 2024

View reviewed changes

mcollina reviewed Sep 2, 2024

View reviewed changes

mcollina requested changes Sep 2, 2024

View reviewed changes

AugustinMauroy added content Issues/pr concerning content learn Issues/pr concerning the learn section labels Sep 12, 2024

ovflowd reviewed Mar 22, 2025

View reviewed changes

mcollina approved these changes Mar 22, 2025

View reviewed changes

avivkeller and others added 4 commits March 22, 2025 09:26

feat(learn): Collecting code coverage

402be75

add links

5db4a92

Signed-off-by: Aviv Keller <[email protected]>

fix coverage command

16d95f4

Co-authored-by: Michael Esteban <[email protected]> Signed-off-by: Aviv Keller <[email protected]>

fixup! add run() API support

0dc9b59

Signed-off-by: Aviv Keller <[email protected]>

avivkeller force-pushed the code-coverage-learn branch from 0ddcfca to 0dc9b59 Compare March 22, 2025 13:27

vercel bot deployed to Preview March 22, 2025 13:28 View deployment

fix formatting

795c6c7

avivkeller removed the blocked label Mar 22, 2025

avivkeller enabled auto-merge March 22, 2025 13:29

avivkeller added the github_actions:pull-request Trigger Pull Request Checks label Mar 22, 2025

github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Mar 22, 2025

avivkeller deployed to Storybook March 22, 2025 13:29 — with GitHub Actions View deployment

vercel bot deployed to Preview March 22, 2025 13:29 View deployment

fix formatting

0754979

avivkeller added the github_actions:pull-request Trigger Pull Request Checks label Mar 22, 2025

github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Mar 22, 2025

avivkeller deployed to Storybook March 22, 2025 13:36 — with GitHub Actions View deployment

vercel bot deployed to Preview March 22, 2025 13:36 View deployment

avivkeller added this pull request to the merge queue Mar 22, 2025

Merged via the queue into nodejs:main with commit a42315e Mar 22, 2025
15 checks passed

avivkeller deleted the code-coverage-learn branch March 22, 2025 13:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(learn): Collecting code coverage #7006

feat(learn): Collecting code coverage #7006

avivkeller commented Aug 24, 2024

vercel bot commented Aug 24, 2024 •

edited

Loading

avivkeller commented Aug 24, 2024

avivkeller commented Aug 24, 2024

AugustinMauroy left a comment

vercel bot commented Aug 24, 2024

AugustinMauroy left a comment

mikeesto left a comment

avivkeller commented Aug 25, 2024 •

edited

Loading

github-actions bot commented Aug 26, 2024 •

edited

Loading

bmuenzenmeyer left a comment

AugustinMauroy commented Sep 2, 2024

mcollina left a comment

mcollina left a comment

avivkeller commented Sep 2, 2024

mcollina commented Sep 2, 2024

avivkeller commented Oct 28, 2024

ovflowd commented Nov 17, 2024

avivkeller commented Nov 17, 2024

ovflowd left a comment

avivkeller commented Mar 22, 2025 •

edited

Loading

mcollina left a comment

github-actions bot commented Mar 22, 2025 •

edited

Loading

avivkeller commented Mar 22, 2025

feat(learn): Collecting code coverage #7006

feat(learn): Collecting code coverage #7006

Conversation

avivkeller commented Aug 24, 2024

Description

Related Issues

Check List

vercel bot commented Aug 24, 2024 • edited Loading

avivkeller commented Aug 24, 2024

avivkeller commented Aug 24, 2024

AugustinMauroy left a comment

Choose a reason for hiding this comment

vercel bot commented Aug 24, 2024

AugustinMauroy left a comment

Choose a reason for hiding this comment

mikeesto left a comment

Choose a reason for hiding this comment

avivkeller commented Aug 25, 2024 • edited Loading

github-actions bot commented Aug 26, 2024 • edited Loading

Unit Test Coverage Report

Unit Test Report

bmuenzenmeyer left a comment

Choose a reason for hiding this comment

AugustinMauroy commented Sep 2, 2024

mcollina left a comment

Choose a reason for hiding this comment

mcollina left a comment

Choose a reason for hiding this comment

avivkeller commented Sep 2, 2024

mcollina commented Sep 2, 2024

avivkeller commented Oct 28, 2024

ovflowd commented Nov 17, 2024

avivkeller commented Nov 17, 2024

ovflowd left a comment

Choose a reason for hiding this comment

avivkeller commented Mar 22, 2025 • edited Loading

mcollina left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 22, 2025 • edited Loading

avivkeller commented Mar 22, 2025

vercel bot commented Aug 24, 2024 •

edited

Loading

avivkeller commented Aug 25, 2024 •

edited

Loading

github-actions bot commented Aug 26, 2024 •

edited

Loading

avivkeller commented Mar 22, 2025 •

edited

Loading

github-actions bot commented Mar 22, 2025 •

edited

Loading